Raj M. Ratwani

62 papers A* 5A 1Misc 4Journal 50Unranked 2
YearRankTypeTitle / Venue / Authors
2025 J jnl
Frontiers Digit. Health
Laura Herrero, Marina Cano, Raj M. Ratwani, Laura Sánchez, Blanca Sánchez, Ramon Sancibrian, Galo Peralta
2025 J jnl
CoRR
Bohao Yang, Rui Yang, Joshua M. Biro, Haoyuan Wang, Jessica L. Handley, Brianna Richardson, Sophia Bessias, Nicoleta J. Economou-Zavlanos, Armando Bedoya, Monica Agrawal, Michael M. Zavlanos, Anand Chowdhury, Raj M. Ratwani, Kai Sun, Kathryn I. Pollak, Michael J. Pencina, Chuan Hong
2025 J jnl
npj Digit. Medicine
Haoyuan Wang, Rui Yang, Mahmoud Alwakeel, Ankit Kayastha, Anand Chowdhury, Joshua M. Biro, Anthony D. Sorrentino, Jessica L. Handley, Sarah Hantzmon, Sophia Bessias, Nicoleta J. Economou-Zavlanos, Armando Bedoya, Monica Agrawal, Raj M. Ratwani, Eric G. Poon, Michael J. Pencina, Kathryn I. Pollak, Chuan Hong
2025 J jnl
npj Digit. Medicine
David L. B. Schwappach, Wolf Hautz, Gert Krummrey, Yvonne Pfeiffer, Raj M. Ratwani
2025 J jnl
npj Digit. Medicine
Joshua M. Biro, Jessica L. Handley, J. Malcolm McCurry, Adam Visconti, Jeffrey Weinfeld, J. Gregory Trafton, Raj M. Ratwani
2025 J jnl
J. Am. Medical Informatics Assoc.
Sadaf Kazi, Zoe Pruitt, Ella S. Franklin, Aaron Z. Hettinger, Raj M. Ratwani, Charlene R. Weir
2025 J jnl
J. Am. Medical Informatics Assoc.
Joshua M. Biro, Jessica L. Handley, James Mickler, Sahithi Reddy, Varsha Kottamasu, Raj M. Ratwani, Nathan K. Cobb
2024 J jnl
J. Am. Medical Informatics Assoc.
Nate C. Apathy, Heather Hartman-Hall, Alberta Tran, Dae Hyun Kim, Raj M. Ratwani, Daniel Marchalik
2024 J jnl
npj Digit. Medicine
Jessica L. Handley, Seth A. Krevat, Allan Fong, Raj M. Ratwani
2024 J jnl
J. Imaging Inform. Medicine
Joseph H. Yacoub, Daniel A. Weitz, Thomas P. Stirrat, Allan Fong, Raj M. Ratwani
2023 J jnl
J. Am. Medical Informatics Assoc.
Teresa Taft, Elizabeth Anne Rudd, Iona Thraen, Sadaf Kazi, Zoe M. Pruitt, Christopher W. Bonk, Deanna-Nicole Busog, Ella S. Franklin, Aaron Z. Hettinger, Raj M. Ratwani, Charlene R. Weir
2023 J jnl
J. Am. Medical Informatics Assoc.
Monika Bapna, Kristen E. Miller, Raj M. Ratwani
2023 J jnl
J. Am. Medical Informatics Assoc.
Monika Bapna, Kristen E. Miller, Raj M. Ratwani
2022 Misc conf
AMIA
Zoe M. Pruitt, Sadaf Kazi, Raj M. Ratwani, Aaron Z. Hettinger
2022 J jnl
npj Digit. Medicine
Ram A. Dixit, Raj M. Ratwani, Jasmine A. Bishop, Kevin A. Schulman, Christopher D. Sharp, Kerry Palakanis, Ethan Booker
2021 J jnl
J. Am. Medical Informatics Assoc.
Deliya B. Wesley, Joseph Blumenthal, Shrenikkumar Shah, Robin Littlejohn, Zoe Pruitt, Ram A. Dixit, Chun-Ju Hsiao, Christine Dymek, Raj M. Ratwani
2021 J jnl
J. Am. Medical Informatics Assoc.
Aaron Z. Hettinger, Edward R. Melnick, Raj M. Ratwani
2021 J jnl
J. Am. Medical Informatics Assoc.
Edward R. Melnick, Shawn Y. Ong, Allan Fong, Vimig Socrates, Raj M. Ratwani, Bidisha Nath, Michael Simonov, Anup Salgia, Brian Williams, Daniel Marchalik, Richard Goldstein, Christine A. Sinsky
2021 J jnl
Appl. Clin. Inform.
Swaminathan Kandaswamy, Zoe Pruitt, Sadaf Kazi, Jenna L. Marquard, Saba Owens, Daniel J. Hoffman, Raj M. Ratwani, Aaron Z. Hettinger
2021 J jnl
npj Digit. Medicine
Laura C. Schubel, Deliya B. Wesley, Ethan Booker, John G. Lock, Raj M. Ratwani
2020 J jnl
Health Informatics J.
Dean F. Sittig, Adam Wright, Enrico W. Coiera, Farah Magrabi, Raj M. Ratwani, David W. Bates, Hardeep Singh
2020 J jnl
J. Am. Medical Informatics Assoc.
Ram A. Dixit, Stephen Hurst, Katharine T. Adams, Christian Boxley, Kristi Lysen-Hendershot, Sonita S. Bennett, Ethan Booker, Raj M. Ratwani
2020 J jnl
J. Am. Medical Informatics Assoc.
Emilie Fortman, A. Zachary Hettinger, Jessica L. Howe, Allan Fong, Zoe Pruitt, Kristen E. Miller, Raj M. Ratwani
2020 J jnl
J. Medical Syst.
Jessica L. Howe, Jennifer L. Reed, Katharine T. Adams, Cara Elsholz, Erin M. Augustine, Andrea T. Cruz, Cynthia Mollen, Michelle L. Pickett, Sara Schmidt, Kristin Stukus, Raj M. Ratwani, Monika K. Goyal
2019 J jnl
J. Biomed. Informatics X
Deliya B. Wesley, Laura Schubel, Chun-Ju Hsiao, Sacha Burn, Jessica L. Howe, Kathryn M. Kellogg, Andrew Lincoln, Bryan Kim, Raj M. Ratwani
2019 J jnl
Appl. Clin. Inform.
Ethan Larsen, Daniel J. Hoffman, Carlos Rivera, Brian M. Kleiner, Christian Wernz, Raj M. Ratwani
2019 J jnl
Appl. Clin. Inform.
Allan Fong, Tomilayo Komolafe, Katharine T. Adams, Arman Cohen, Jessica L. Howe, Raj M. Ratwani
2019 J jnl
J. Am. Medical Informatics Assoc.
Jessica M. Ray, Raj M. Ratwani, Christine A. Sinsky, Richard M. Frankel, Mark W. Friedberg, Seth M. Powsner, David I. Rosenthal, Robert M. Wachter, Edward R. Melnick
2019 J jnl
J. Digit. Imaging
Linda C. Kelahan, Allan Fong, Joseph Blumenthal, Swaminathan Kandaswamy, Raj M. Ratwani, Ross W. Filice
2018 J jnl
J. Am. Medical Informatics Assoc.
Raj M. Ratwani, Erica L. Savage, Amy Will, Ryan Arnold, Saif S. Khairat, Kristen E. Miller, Rollin J. Fairbanks, Michael L. Hodgkins, A. Zachary Hettinger
2018 J jnl
Appl. Clin. Inform.
Saif Khairat, Gary Burke, Heather Archambault, Todd A. Schwartz, James Larson, Raj M. Ratwani
2018 Misc conf
AMIA
J. Marc Overhage, Titus K. Schleyer, Shaun J. Grannis, Allan Fong, Raj M. Ratwani
2018 J jnl
J. Biomed. Informatics
Allan Fong, Katharine T. Adams, Michael J. Gaunt, Jessica L. Howe, Kathryn M. Kellogg, Raj M. Ratwani
2018 J jnl
J. Am. Medical Informatics Assoc.
Ethan Larsen, Allan Fong, Christian Wernz, Raj M. Ratwani
2018 J jnl
J. Am. Medical Informatics Assoc.
Kristen E. Miller, Danielle Mosby, Muge Capan, Rebecca Kowalski, Raj M. Ratwani, Yaman Noaiseh, Rachel Kraft, Sanford Schwartz, William S. Weintraub, Ryan Arnold
2018 J jnl
J. Medical Syst.
Allan Fong, Tracy C. Kim, Raj M. Ratwani, Kathryn M. Kellogg
2017 A conf
ECIR
Arman Cohan, Allan Fong, Nazli Goharian, Raj M. Ratwani
2017 J jnl
CoRR
Arman Cohan, Allan Fong, Nazli Goharian, Raj M. Ratwani
2017 A* conf
CHI
Allan Fong, A. Zachary Hettinger, Raj M. Ratwani
2017 J jnl
J. Am. Medical Informatics Assoc.
Raj M. Ratwani, A. Zachary Hettinger, Allison Kosydar, Rollin J. Fairbanks, Michael L. Hodgkins
2017 J jnl
Appl. Clin. Inform.
Katharine T. Adams, Jessica L. Howe, Allan Fong, Joseph Puthumana, Kathryn M. Kellogg, Michael J. Gaunt, Raj M. Ratwani
2017 J jnl
J. Am. Medical Informatics Assoc.
Erica L. Savage, Rollin J. Fairbanks, Raj M. Ratwani
2017 J jnl
J. Am. Medical Informatics Assoc.
Raj M. Ratwani, A. Zachary Hettinger, Rollin J. Fairbanks
2017 conf
BCB
Arman Cohan, Allan Fong, Raj M. Ratwani, Nazli Goharian
2017 J jnl
CoRR
Arman Cohan, Allan Fong, Raj M. Ratwani, Nazli Goharian
2017 J jnl
Int. J. Medical Informatics
Allan Fong, Nicole Harriott, Donna M. Walters, Hanan Foley, Richard Morrissey, Raj M. Ratwani
2016 conf
HICSS
Ethan Larsen, Christiane Haubitz, Christian Wernz, Raj M. Ratwani
2016 J jnl
Appl. Clin. Inform.
Terry Fairbanks, Erica Savage, Katie Adams, Michael Wittie, Edna Boone, Andrew Hayden, Janey Barnes, Zach Hettinger, Andrew Gettinger, Raj M. Ratwani
2015 J jnl
J. Am. Medical Informatics Assoc.
Raj M. Ratwani, Allan Fong
2015 J jnl
J. Am. Medical Informatics Assoc.
Raj M. Ratwani, Rollin J. Fairbanks, A. Zachary Hettinger, Natalie C. Benda
2015 J jnl
J. Biomed. Informatics
Allan Fong, A. Zachary Hettinger, Raj M. Ratwani
2014 Misc conf
AMIA
Allan Fong, Ranjeev Mittu, Raj M. Ratwani, James A. Reggia
2014 A* conf
CHI
J. Gregory Trafton, Raj M. Ratwani
2011 J jnl
Hum. Comput. Interact.
Raj M. Ratwani, J. Gregory Trafton
2011 J jnl
Cogn. Syst. Res.
J. Gregory Trafton, Erik M. Altmann, Raj M. Ratwani
2011 Misc conf
CogSIMA
Elan Freedy, Lou Lartigue, Lisa Chung, Raj M. Ratwani, Gershon Weltman, James Zanol, Brian Pierce, Marvin S. Cohen
2010 J jnl
Top. Cogn. Sci.
Raj M. Ratwani, J. Gregory Trafton
2010 J jnl
Hum. Factors
Raj M. Ratwani
2010 A* conf
HRI
Raj M. Ratwani, J. Malcolm McCurry, J. Gregory Trafton
2009 J jnl
Hum. Factors
Leonard A. Breslow, Raj M. Ratwani, J. Gregory Trafton
2008 A* conf
HRI
J. Gregory Trafton, Magdalena D. Bugajska, Benjamin R. Fransen, Raj M. Ratwani
2008 A* conf
CHI
Raj M. Ratwani, J. Malcolm McCurry, J. Gregory Trafton
redb/extractors/decompiler/apk/analyzer.py
← Index redb/extractors/decompiler/apk/analyzer.py python
"""APK Code Analyzer — orchestrates androguard + JADX + apktool analysis.

This is the APK equivalent of BinaryNinjaDecompiler in
redb/extractors/decompiler/bninja/decompiler.py.
"""

import math
import os
import tempfile
from collections import Counter
from concurrent.futures import ThreadPoolExecutor, as_completed
from typing import Any, Dict, List, Optional, Set

from redb.extractors.decompiler.apk.apktool_wrapper import ApktoolDisassembler
from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
from redb.extractors.decompiler.apk.library_filter import LibraryFilter
from redb.extractors.decompiler.apk.method_extractor import (
    compute_minhash,
    compute_prime_product_smali,
    compute_sha256,
    compute_ssdeep,
    compute_tlsh,
    count_call_instructions,
    dalvik_to_java_class,
    dalvik_to_java_prototype,
    detect_obfuscation_indicators,
)
from redb.extractors.decompiler.apk.smali_normalization import normalize_method_body
from redb.extractors.decompiler.apk.smali_cfg import compute_cfg_metrics
from redb.extractors.decompiler.apk.smali_parser import SmaliParser


class APKCodeAnalyzer:
    """Orchestrates APK code analysis combining three tools.

    Combines androguard (call graphs, xrefs, method enumeration),
    JADX (Java decompilation), and apktool (smali disassembly).
    """

    def __init__(
        self,
        filepath: str,
        timeout: int = 600,
        log=None,
        decompile_modules: Set[str] = None,
    ):
        self.filepath = filepath
        self.timeout = timeout
        self.log = log
        self.decompile_modules = decompile_modules or {"all"}
        self.min_instructions = int(
            os.getenv("APK_MIN_METHOD_INSTRUCTIONS", "5")
        )
        self.library_filter = LibraryFilter()
        self.jadx = JADXDecompiler(log=log)
        self.apktool = ApktoolDisassembler(log=log)

        self._temp_dirs = []

    def extract(self) -> Dict[str, Any]:
        """Run full APK code analysis.

        Returns dict with keys:
            decompiled_content, decompiled_refs,
            smali_content, smali_refs,
            similarity_metrics, strings, analysis_errors
        """
        results = {
            "decompiled_content": [],
            "decompiled_refs": [],
            "smali_content": [],
            "smali_refs": [],
            "similarity_metrics": [],
            "cfg": [],
            "strings": [],
            "analysis_errors": [],
        }

        # Create temp directories
        jadx_dir = tempfile.mkdtemp(prefix="redb_jadx_")
        apktool_dir = tempfile.mkdtemp(prefix="redb_apktool_")
        self._temp_dirs.extend([jadx_dir, apktool_dir])

        # Step 1-3: Run JADX, apktool, and androguard in parallel
        jadx_success = False
        apktool_success = False
        androguard_result = None

        with ThreadPoolExecutor(max_workers=3) as executor:
            futures = {}
            futures[executor.submit(self.jadx.decompile, self.filepath, jadx_dir)] = "jadx"
            futures[executor.submit(self.apktool.disassemble, self.filepath, apktool_dir)] = "apktool"
            futures[executor.submit(self._run_androguard)] = "androguard"

            for future in as_completed(futures):
                tool = futures[future]
                try:
                    result = future.result()
                    if tool == "jadx":
                        jadx_success = result
                    elif tool == "apktool":
                        apktool_success = result
                    elif tool == "androguard":
                        androguard_result = result
                except Exception as e:
                    if self.log:
                        self.log.error(f"{tool} failed: {e}")
                    results["analysis_errors"].append({
                        "class_name": None,
                        "method_name": None,
                        "error_location": tool,
                        "error_message": str(e),
                        "error_type": type(e).__name__,
                    })

        if androguard_result is None:
            if self.log:
                self.log.error("Androguard analysis failed — cannot proceed")
            return results

        apk_obj, dexs, analysis = androguard_result

        # Step 4b: Extract strings from DEX files
        try:
            results["strings"] = self._extract_strings(dexs)
        except Exception as e:
            if self.log:
                self.log.error(f"String extraction failed: {e}")
            results["analysis_errors"].append({
                "class_name": None,
                "method_name": None,
                "error_location": "strings",
                "error_message": f"String extraction failed: {e}",
                "error_type": type(e).__name__,
            })

        # Step 5: Parse smali output
        smali_methods = {}
        if apktool_success:
            try:
                smali_dirs = self.apktool.get_smali_directories(apktool_dir)
                for sdir in smali_dirs:
                    smali_methods.update(SmaliParser.parse_smali_directory(sdir))
            except Exception as e:
                if self.log:
                    self.log.error(f"Smali parsing failed: {e}")
                results["analysis_errors"].append({
                    "class_name": None,
                    "method_name": None,
                    "error_location": "apktool",
                    "error_message": f"Smali parsing failed: {e}",
                    "error_type": type(e).__name__,
                })

        # Step 6: Parse Java output
        java_methods = {}
        if jadx_success:
            try:
                java_methods = self.jadx.parse_java_methods(jadx_dir)
            except Exception as e:
                if self.log:
                    self.log.error(f"Java parsing failed: {e}")
                results["analysis_errors"].append({
                    "class_name": None,
                    "method_name": None,
                    "error_location": "jadx",
                    "error_message": f"Java parsing failed: {e}",
                    "error_type": type(e).__name__,
                })

        if not apktool_success and self.log:
            self.log.info(
                "apktool failed — falling back to androguard disassembly"
            )

        # Step 7-8: Process each method from androguard
        seen_decompiled_hashes = set()
        seen_smali_hashes = set()

        try:
            for method in analysis.get_methods():
                try:
                    self._process_method(
                        method,
                        smali_methods,
                        java_methods,
                        results,
                        seen_decompiled_hashes,
                        seen_smali_hashes,
                    )
                except Exception as e:
                    method_name = "unknown"
                    class_name = "unknown"
                    try:
                        if not method.is_external():
                            enc = method.get_method()
                            class_name = enc.get_class_name()
                            method_name = enc.get_name()
                    except Exception:
                        pass
                    results["analysis_errors"].append({
                        "class_name": class_name,
                        "method_name": method_name,
                        "error_location": "analysis",
                        "error_message": str(e),
                        "error_type": type(e).__name__,
                    })
        except Exception as e:
            if self.log:
                self.log.error(f"Method enumeration failed: {e}")
            results["analysis_errors"].append({
                "class_name": None,
                "method_name": None,
                "error_location": "androguard",
                "error_message": f"Method enumeration failed: {e}",
                "error_type": type(e).__name__,
            })

        if self.log:
            stats = self.library_filter.get_filter_stats()
            self.log.info(
                f"APK analysis complete: {stats['user']} user methods, "
                f"{stats['library']} library methods filtered, "
                f"{len(results['decompiled_content'])} decompiled, "
                f"{len(results['smali_content'])} smali, "
                f"{len(results['strings'])} strings"
            )

        return results

    def _run_androguard(self):
        """Run androguard analysis on the APK."""
        from androguard.misc import AnalyzeAPK
        return AnalyzeAPK(self.filepath)

    def _process_method(
        self,
        method,
        smali_methods: Dict,
        java_methods: Dict,
        results: Dict,
        seen_decompiled: set,
        seen_smali: set,
    ):
        """Process a single method from androguard analysis."""
        # Skip external methods (no code body)
        if method.is_external():
            return

        encoded = method.get_method()
        class_name = encoded.get_class_name()
        method_name = encoded.get_name()
        descriptor = encoded.get_descriptor()

        # Build method key for cross-tool matching
        method_key = SmaliParser.make_method_key(class_name, method_name, descriptor)

        # Check if library
        is_lib = self.library_filter.is_library(class_name)
        method_type = "LIBRARY" if is_lib else "USER"

        # Skip library methods for content tables (but they're still in xrefs)
        if is_lib:
            return

        # Get xrefs
        # In androguard 4.x, xref tuples are (ClassAnalysis, MethodAnalysis, offset).
        # The MethodAnalysis wrapper doesn't expose get_class_name()/get_name()
        # directly — we need to unwrap via .get_method() first.
        callers = []
        callees = []
        try:
            for ref_class, ref_method, offset in method.get_xref_from():
                try:
                    enc = ref_method.get_method()
                    caller_key = f"{enc.get_class_name()}->{enc.get_name()}"
                except AttributeError:
                    # Fallback for older androguard where ref_method is EncodedMethod
                    caller_key = f"{ref_method.get_class_name()}->{ref_method.get_name()}"
                callers.append(caller_key)
        except Exception:
            pass

        try:
            for ref_class, ref_method, offset in method.get_xref_to():
                try:
                    enc = ref_method.get_method()
                    callee_key = f"{enc.get_class_name()}->{enc.get_name()}"
                except AttributeError:
                    callee_key = f"{ref_method.get_class_name()}->{ref_method.get_name()}"
                callees.append(callee_key)
        except Exception:
            pass

        # Look up smali body
        smali_method = smali_methods.get(method_key)
        smali_body = None
        smali_normalized = None
        smali_hash = None
        instruction_count = 0
        register_count = 0

        if smali_method:
            smali_body = smali_method.body
            instruction_count = smali_method.instruction_count
            register_count = smali_method.register_count
        else:
            # Fallback: use androguard's own disassembler
            smali_body, instruction_count, register_count = (
                self._disassemble_with_androguard(encoded)
            )

        # Apply minimum instruction filter
        if instruction_count < self.min_instructions:
            return

        if smali_body:
            smali_normalized = SmaliParser.normalize_smali_body(smali_body)
            if smali_normalized:
                smali_hash = compute_sha256(smali_normalized)

        if not smali_hash:
            return

        # Compute obfuscation indicators from smali
        obfuscation = detect_obfuscation_indicators(
            method_name, class_name, smali_body, instruction_count
        )

        # Compute CFG metrics early — needed for both content tables and cfg table
        cfg_metrics = None
        if smali_body:
            try:
                cfg_metrics = compute_cfg_metrics(smali_body)
            except Exception:
                pass

        # Smali content (deduplicated)
        if smali_hash and smali_hash not in seen_smali:
            seen_smali.add(smali_hash)
            results["smali_content"].append({
                "smali_method_hash": smali_hash,
                "smali_method": smali_body,
                "smali_method_type": method_type,
                "smali_instructions_count": instruction_count,
                "smali_register_count": register_count,
                "smali_has_string_encryption": obfuscation.get("has_string_encryption", False),
                "smali_has_reflection_calls": obfuscation.get("has_reflection_calls", False),
                "smali_excessive_goto_count": obfuscation.get("excessive_goto_count", False),
                "smali_flattened_score": cfg_metrics.flattened_score if cfg_metrics else 0.0,
                "smali_mba_score": cfg_metrics.mba_score if cfg_metrics else 0.0,
            })

        # Smali reference (per-binary)
        ssdeep_val = compute_ssdeep(smali_normalized) if smali_normalized else None
        tlsh_val = compute_tlsh(smali_normalized) if smali_normalized else None

        # Semantically normalized ssdeep/TLSH (analogous to Binja's ssdeep_llil/tlsh_llil)
        ssdeep_normalized_val = None
        tlsh_normalized_val = None
        if smali_normalized:
            normalized_lines = normalize_method_body(smali_normalized, level="opcode_api")
            if normalized_lines:
                normalized_text = "\n".join(normalized_lines)
                ssdeep_normalized_val = compute_ssdeep(normalized_text)
                tlsh_normalized_val = compute_tlsh(normalized_text)

        # Look up Java source
        java_class = dalvik_to_java_class(class_name)
        java_key_candidates = [
            f"{java_class}.{method_name}",
        ]
        java_source = None
        decompiled_hash = None

        for jk in java_key_candidates:
            for key, source in java_methods.items():
                if key.startswith(jk):
                    java_source = source
                    break
            if java_source:
                break

        if java_source:
            # Normalize and hash decompiled content
            normalized_java = _normalize_java(java_source)
            decompiled_hash = compute_sha256(normalized_java)

            # Decompiled content (deduplicated)
            if decompiled_hash not in seen_decompiled:
                seen_decompiled.add(decompiled_hash)
                results["decompiled_content"].append({
                    "decompiled_method_hash": decompiled_hash,
                    "decompiled_method": java_source,
                    "decompiled_method_type": method_type,
                    "decompiled_has_string_encryption": obfuscation.get("has_string_encryption", False),
                    "decompiled_has_reflection_calls": obfuscation.get("has_reflection_calls", False),
                    "decompiled_excessive_goto_count": obfuscation.get("excessive_goto_count", False),
                })

            # Decompiled reference
            method_prototype = dalvik_to_java_prototype(
                method_name, descriptor, class_name
            )
            results["decompiled_refs"].append({
                "decompiled_method_hash": decompiled_hash,
                "smali_method_hash": smali_hash,
                "decompiled_class_name": dalvik_to_java_class(class_name),
                "decompiled_method_name": method_name,
                "decompiled_method_signature": descriptor,
                "decompiled_method_prototype": method_prototype,
                "functions_caller": callers,
                "functions_call": callees,
            })

        # Smali reference
        if smali_hash:
            results["smali_refs"].append({
                "smali_method_hash": smali_hash,
                "decompiled_method_hash": decompiled_hash,
                "smali_class_name": dalvik_to_java_class(class_name),
                "smali_method_name": method_name,
                "smali_method_signature": descriptor,
                "ssdeep_smali": ssdeep_val,
                "tlsh_smali": tlsh_val,
            })

        # Similarity metrics (content-based fuzzy matching only)
        if smali_hash and smali_normalized:
            minhash_sig = compute_minhash(smali_normalized)
            sim_entry = {
                "smali_method_hash": smali_hash,
                "cyclomatic_complexity": cfg_metrics.cyclomatic_complexity if cfg_metrics else None,
                "ssdeep_smali": ssdeep_val,
                "tlsh_smali": tlsh_val,
                "ssdeep_smali_normalized": ssdeep_normalized_val,
                "tlsh_smali_normalized": tlsh_normalized_val,
                "minhash": minhash_sig or [],
            }
            results["similarity_metrics"].append(sim_entry)

        # CFG entry (structural/topological features)
        if smali_hash and cfg_metrics and smali_body:
            prime_product = compute_prime_product_smali(smali_body)
            call_count = count_call_instructions(smali_body)
            cfg_entry = {
                "smali_method_hash": smali_hash,
                "cfg_topology_hash": cfg_metrics.cfg_topology_hash,
                "block_count": cfg_metrics.block_count,
                "edge_count": cfg_metrics.edge_count,
                "cfg_instructions_count": instruction_count,
                "call_count": call_count,
                "cyclomatic_complexity": cfg_metrics.cyclomatic_complexity,
                "loop_count": cfg_metrics.loop_count,
                "max_depth": cfg_metrics.max_depth,
                "max_fan_out": cfg_metrics.max_fan_out,
                "md_index_topdown": cfg_metrics.md_index_topdown,
                "md_index_bottomup": cfg_metrics.md_index_bottomup,
                "prime_product_smali": prime_product,
                "cfg_feature_tlsh": cfg_metrics.cfg_feature_tlsh,
                "wl_minhash": cfg_metrics.wl_minhash,
                "bb_features": cfg_metrics.block_features,
                "cfg_adjacency": cfg_metrics.cfg_adjacency,
            }
            results["cfg"].append(cfg_entry)

    @staticmethod
    def _string_entropy(s: str) -> float:
        """Compute Shannon entropy of a string."""
        if not s:
            return 0.0
        freq = Counter(s)
        length = len(s)
        return -sum(
            (count / length) * math.log2(count / length)
            for count in freq.values()
        )

    def _extract_strings(self, dexs) -> List[Dict[str, Any]]:
        """Extract deduplicated strings from all DEX objects.

        Uses androguard's get_strings() on each DEX, deduplicates by value,
        and computes entropy — matching the Binja StringAnalysis output format
        so IOCExtractorFromResults can consume them identically.

        Returns list of dicts with keys:
            string, string_encoding, string_offset, string_length, string_entropy
        """
        seen = set()
        strings = []
        offset_counter = 0

        for dex in dexs:
            try:
                dex_strings = dex.get_strings()
            except Exception:
                continue

            if not dex_strings:
                continue

            for s in dex_strings:
                if not s or s in seen:
                    continue
                # DEX MUTF-8 strings may contain unpaired surrogates (e.g. \ud800)
                # that are invalid UTF-8 and will fail ClickHouse insert
                s = s.encode('utf-8', errors='replace').decode('utf-8')
                if not s or s in seen:
                    continue
                seen.add(s)

                strings.append({
                    "string": s,
                    "string_encoding": "UTF8",
                    "string_offset": offset_counter,
                    "string_length": len(s),
                    "string_entropy": self._string_entropy(s),
                })
                offset_counter += 1

        return strings

    @staticmethod
    def _disassemble_with_androguard(encoded):
        """Fallback disassembly using androguard when apktool fails.

        Returns (smali_body, instruction_count, register_count).
        """
        code = encoded.get_code()
        if not code:
            return None, 0, 0

        register_count = code.get_registers_size()
        lines = []
        instruction_count = 0

        try:
            bytecode = code.get_bc()
            if not bytecode:
                return None, 0, register_count

            for instruction in bytecode.get_instructions():
                op_name = instruction.get_name()
                output = instruction.get_output()
                if output:
                    output = _normalize_androguard_operands(op_name, output)
                    lines.append(f"    {op_name} {output}")
                else:
                    lines.append(f"    {op_name}")
                instruction_count += 1
        except Exception:
            return None, 0, register_count

        if not lines:
            return None, 0, register_count

        smali_body = "\n".join(lines)
        return smali_body, instruction_count, register_count

    def cleanup(self):
        """Remove temporary directories."""
        import shutil
        for d in self._temp_dirs:
            try:
                if os.path.isdir(d):
                    shutil.rmtree(d)
            except Exception:
                pass
        self._temp_dirs.clear()


def _normalize_androguard_operands(op_name: str, output: str) -> str:
    """Normalize androguard instruction output to match apktool smali format.

    Androguard's get_output() differs from apktool in two key ways:
    1. invoke-* operands lack {braces} around registers:
       androguard: 'v0, v1, Lcom/Foo;->bar()V'
       apktool:    '{v0, v1}, Lcom/Foo;->bar()V'
    2. Field instructions use a space instead of colon between name and type:
       androguard: 'v0, v1, LA;->field Ljava/lang/String;'
       apktool:    'v0, v1, LA;->field:Ljava/lang/String;'
    """
    # invoke-* instructions: wrap register args in {braces}
    if op_name.startswith("invoke-"):
        # Find the class/method reference (starts with L or [)
        # Split on ', ' and find where the reference begins
        parts = output.split(", ")
        reg_parts = []
        ref_idx = None
        for i, part in enumerate(parts):
            stripped = part.strip()
            if stripped.startswith("L") or stripped.startswith("["):
                ref_idx = i
                break
            reg_parts.append(part)

        if ref_idx is not None and reg_parts:
            regs = ", ".join(reg_parts)
            ref = ", ".join(parts[ref_idx:])
            return "{" + regs + "}, " + ref
        elif reg_parts:
            # No reference found — just wrap all as registers
            return "{" + ", ".join(reg_parts) + "}"

    # Field instructions: fix 'field Ltype;' → 'field:Ltype;'
    if op_name.startswith(("iget", "iput", "sget", "sput")):
        # Pattern: '... ClassName;->fieldName Ltype;' or '... ClassName;->fieldName [Ltype;'
        # The space between fieldName and the type descriptor should be a colon
        arrow_idx = output.find("->")
        if arrow_idx != -1:
            after_arrow = output[arrow_idx + 2:]
            # Find the space before the type descriptor
            space_idx = after_arrow.find(" ")
            if space_idx != -1:
                remaining = after_arrow[space_idx + 1:]
                # Check that what follows is a type descriptor
                if remaining.startswith(("L", "[", "Z", "B", "S", "C",
                                         "I", "J", "F", "D")):
                    after_arrow = after_arrow[:space_idx] + ":" + remaining
                    output = output[:arrow_idx + 2] + after_arrow

    return output


def _normalize_java(source: str) -> str:
    """Normalize Java source for consistent hashing.

    Strip leading/trailing whitespace, normalize indentation.
    """
    lines = []
    for line in source.split("\n"):
        stripped = line.strip()
        if stripped:
            lines.append(stripped)
    return "\n".join(lines)