Rahul Makkar

22 papers B 1C 1Journal 8Unranked 12
YearRankTypeTitle / Venue / Authors
2026 J jnl
IEEE Trans. Green Commun. Netw.
Rahul Makkar, Sandhya Soni, Divyang Rawal, Nikhil Sharma, Vijay Kumar Chakka, Pei Xiao
2025 conf
VTC2025-Spring
Sandhya Soni, Rahul Makkar, Divyang Rawal, Gurinder Singh, Vivek Ashok Bohara, Zi Long Liu
2025 conf
ANTS
Vijay Kumar Chakka, Rahul Makkar, Divyang Rawal, Rohit Rana, Pei Xiao
2024 conf
VTC Spring
Rahul Makkar, Monika Jain, Divyang Rawal, Nikhil Sharma, Vijay Kumar Chakka
2024 B conf
WCNC
Rahul Makkar, Monika Jain, Sandhya Soni, Divyang Rawal, Nikhil Sharma
2024 J jnl
IEEE Trans. Green Commun. Netw.
Sandhya Soni, Rahul Makkar, Divyang Rawal, Nikhil Sharma
2024 conf
ANTS
Sandhya Soni, Rahul Makkar, Divyang Rawal, Nikhil Sharma, Vijay Kumar Chakka
2023 conf
ICOIN
Sandhya Soni, Rahul Makkar, Divyang Rawal, Nikhil Sharma
2023 J jnl
IEEE Commun. Lett.
Rahul Makkar, Dharmendra Dixit, Divyang Rawal, Nikhil Sharma, Sanjeev Sharma
2023 J jnl
IEEE Syst. J.
Sandhya Soni, Rahul Makkar, Divyang Rawal, Nikhil Sharma
2022 conf
ICTC
Rahul Makkar, Sandhya Soni, Divyang Rawal, Nikhil Sharma, Laxmikant Minz
2022 conf
VTC Fall
Rahul Makkar, Venugopalachary Kotha, Divyang Rawal, Vijay Kumar Chakka, Nikhil Sharma
2022 J jnl
Int. J. Commun. Syst.
Rahul Makkar, Divyang Rawal, Nikhil Sharma, Akash Gupta
2022 J jnl
Trans. Emerg. Telecommun. Technol.
Rahul Makkar, Sandhya Soni, Divyang Rawal, Nikhil Sharma, Parul Garg
2021 conf
ANTS
Tanmay Singhwi, Samya Andra, Sai Jaswanth Seelam, Rahul Makkar, Divyang Rawal, Nikhil Sharma
2021 J jnl
Phys. Commun.
Monika Jain, Rahul Makkar, Divyang Rawal, Ranjan Gangopadhyay
2021 conf
ICTC
Sandhya Soni, Rahul Makkar, Tanmay Singhwi, Divyang Rawal, Nikhil Sharma, Laxmikant Minz
2021 C conf
TENCON
Rahul Makkar, Venugopalachary Kotha, Neha Sharma, Nilesh Bankar, Divyang Rawal, Vijay Kumar Chakka
2021 J jnl
Trans. Emerg. Telecommun. Technol.
Rahul Makkar, Akshita Gupta, Divyang Rawal, Nikhil Sharma
2020 conf
IEEE ANTS
Rahul Makkar, Venugopalachary Kotha, Divyang Rawal, Vijay Kumar Chakka, Nikhil Sharma
2020 conf
5G World Forum
Rahul Makkar, Venugopalachary Kotha, M. Sheeba Kumari, Divyang Rawal, Vijay Kumar Chakka, Navin Kumar
2019 conf
VTC Spring
Akshita Gupta, Rahul Makkar, Divyang Rawal, Nikhil Sharma, Dushantha Nalin K. Jayakody
tests/unit/test_apk_jadx_wrapper.py
← Index tests/unit/test_apk_jadx_wrapper.py python
"""
Unit tests for JADX wrapper subprocess management and output parsing.

All subprocess calls are mocked — no JADX/Java installation required.
"""
import os
import tempfile
import textwrap

import pytest
from unittest.mock import MagicMock, patch, call

pytestmark = [pytest.mark.unit, pytest.mark.apk, pytest.mark.decompile]


class TestJADXDecompiler:
    """Tests for JADXDecompiler subprocess wrapper."""

    @patch.dict(os.environ, {}, clear=False)
    def test_init_defaults(self):
        os.environ.pop("JADX_PATH", None)
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        assert j.jadx_path == "jadx"
        assert j.timeout == 300

    def test_init_custom_path(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler(jadx_path="/usr/local/bin/jadx", timeout=300)
        assert j.jadx_path == "/usr/local/bin/jadx"
        assert j.timeout == 300

    def test_init_from_env(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        with patch.dict(os.environ, {"JADX_PATH": "/opt/jadx/bin/jadx", "JADX_TIMEOUT": "120"}):
            j = JADXDecompiler()
            assert j.jadx_path == "/opt/jadx/bin/jadx"
            assert j.timeout == 120

    @patch("subprocess.Popen")
    def test_decompile_success(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        mock_proc = MagicMock()
        mock_proc.communicate.return_value = ("output", "")
        mock_proc.returncode = 0
        mock_popen.return_value = mock_proc

        j = JADXDecompiler()
        result = j.decompile("/test.apk", "/output")
        assert result is True

    @patch("subprocess.Popen")
    def test_decompile_nonzero_exit_no_sources(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        mock_proc = MagicMock()
        mock_proc.communicate.return_value = ("", "error msg")
        mock_proc.returncode = 1
        mock_popen.return_value = mock_proc

        j = JADXDecompiler(log=MagicMock())
        result = j.decompile("/test.apk", "/nonexistent_output")
        assert result is False

    @patch("subprocess.Popen")
    def test_decompile_timeout(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        import subprocess
        mock_proc = MagicMock()
        mock_proc.communicate.side_effect = subprocess.TimeoutExpired(cmd="jadx", timeout=10)
        mock_proc.pid = 12345
        mock_popen.return_value = mock_proc

        with patch("os.getpgid", return_value=12345), \
             patch("os.killpg"):
            j = JADXDecompiler(timeout=10, log=MagicMock())
            result = j.decompile("/test.apk", "/output")
            assert result is False

    @patch("subprocess.Popen", side_effect=FileNotFoundError)
    def test_decompile_not_found(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler(log=MagicMock())
        result = j.decompile("/test.apk", "/output")
        assert result is False

    @patch("subprocess.Popen")
    def test_decompile_command_args(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        mock_proc = MagicMock()
        mock_proc.communicate.return_value = ("", "")
        mock_proc.returncode = 0
        mock_popen.return_value = mock_proc

        j = JADXDecompiler(jadx_path="/opt/jadx")
        j.decompile("/test.apk", "/output")

        cmd = mock_popen.call_args[0][0]
        assert cmd[0] == "/opt/jadx"
        assert "--no-res" in cmd
        assert "--no-imports" in cmd
        assert "--threads-count" in cmd
        assert "/test.apk" in cmd

    def test_parse_java_methods_empty_dir(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        result = j.parse_java_methods("/nonexistent")
        assert result == {}

    def test_parse_java_methods_with_files(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        with tempfile.TemporaryDirectory() as tmpdir:
            sources_dir = os.path.join(tmpdir, "sources", "com", "example")
            os.makedirs(sources_dir)

            java_content = textwrap.dedent("""\
                package com.example;

                public class MyClass {
                    public void doStuff(int x) {
                        System.out.println(x);
                    }

                    private String getName() {
                        return "test";
                    }
                }
            """)
            with open(os.path.join(sources_dir, "MyClass.java"), "w") as f:
                f.write(java_content)

            j = JADXDecompiler()
            methods = j.parse_java_methods(tmpdir)
            assert len(methods) >= 1

    def test_extract_methods_from_java(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        source = textwrap.dedent("""\
            public void foo(int x) {
                if (x > 0) {
                    System.out.println(x);
                }
            }
        """)
        j = JADXDecompiler()
        methods = j._extract_methods_from_java(source, "com.example.Test")
        assert len(methods) == 1
        key = list(methods.keys())[0]
        assert "foo" in key

    def test_is_method_declaration_valid(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        result = j._is_method_declaration("    public void foo(int x) {")
        assert result is not None
        assert result[0] == "foo"

    def test_is_method_declaration_control_flow(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        # 'if', 'for', etc. should not be recognized as methods
        assert j._is_method_declaration("        if (x > 0) {") is None
        assert j._is_method_declaration("        for (int i = 0; i < 10; i++) {") is None

    def test_is_method_declaration_static(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        result = j._is_method_declaration("    public static void main(String[] args) {")
        assert result is not None
        assert result[0] == "main"