Nadav Borenstein

24 papers A* 3Journal 13Unranked 8
YearRankTypeTitle / Venue / Authors
2025 J jnl
CoRR
Sekh Mainul Islam, Nadav Borenstein, Siddhesh Pawar, Haeun Yu, Arnav Arora, Isabelle Augenstein
2025 conf
ACL (2)
Nadav Borenstein, Greta Warren, Desmond Elliott, Isabelle Augenstein
2025 J jnl
CoRR
Nadav Borenstein, Greta Warren, Desmond Elliott, Isabelle Augenstein
2025 conf
NAACL (Long Papers)
Nadav Borenstein, Arnav Arora, Lucie-Aimée Kaffee, Isabelle Augenstein
2025 J jnl
CoRR
Nadav Borenstein
2024 J jnl
CoRR
Anej Svete, Nadav Borenstein, Mike Zhou, Isabelle Augenstein, Ryan Cotterell
2024 A* conf
EMNLP
Anej Svete, Nadav Borenstein, Mike Zhou, Isabelle Augenstein, Ryan Cotterell
2024 conf
EMNLP (Findings)
Yuxia Wang, Revanth Gangi Reddy, Zain Muhammad Mujahid, Arnav Arora, Aleksandr Rubashevskii, Jiahui Geng, Osama Mohammed Afzal, Liangming Pan, Nadav Borenstein, Aditya Pillai, Isabelle Augenstein, Iryna Gurevych, Preslav Nakov
2024 A* conf
AAAI
Hen Emuna, Nadav Borenstein, Xin Qian, Hyeonsu B. Kang, Joel Chan, Aniket Kittur, Dafna Shahaf
2024 J jnl
CoRR
Nadav Borenstein, Arnav Arora, Lucie-Aimée Kaffee, Isabelle Augenstein
2024 conf
EMNLP (Findings)
Dustin Wright, Arnav Arora, Nadav Borenstein, Srishti Yadav, Serge J. Belongie, Isabelle Augenstein
2024 J jnl
CoRR
Dustin Wright, Arnav Arora, Nadav Borenstein, Srishti Yadav, Serge J. Belongie, Isabelle Augenstein
2024 conf
ACL (1)
Nadav Borenstein, Anej Svete, Robin Chan, Josef Valvoda, Franz Nowak, Isabelle Augenstein, Eleanor Chodroff, Ryan Cotterell
2024 J jnl
CoRR
Nadav Borenstein, Anej Svete, Robin Shing Moon Chan, Josef Valvoda, Franz Nowak, Isabelle Augenstein, Eleanor Chodroff, Ryan Cotterell
2023 J jnl
CoRR
Yuxia Wang, Revanth Gangi Reddy, Zain Muhammad Mujahid, Arnav Arora, Aleksandr Rubashevskii, Jiahui Geng, Osama Mohammed Afzal, Liangming Pan, Nadav Borenstein, Aditya Pillai, Isabelle Augenstein, Iryna Gurevych, Preslav Nakov
2023 J jnl
CoRR
Hen Emuna, Nadav Borenstein, Xin Qian, Hyeonsu B. Kang, Joel Chan, Aniket Kittur, Dafna Shahaf
2023 conf
ACL (Findings)
Nadav Borenstein, Karolina Stanczak, Thea Rolskov, Natacha Klein Käfer, Natalia da Silva Perez, Isabelle Augenstein
2023 J jnl
CoRR
Nadav Borenstein, Karolina Stanczak, Thea Rolskov, Natalia da Silva Perez, Natacha Klein Käfer, Isabelle Augenstein
2023 conf
ACL (1)
Nadav Borenstein, Natalia da Silva Perez, Isabelle Augenstein
2023 J jnl
CoRR
Nadav Borenstein, Natalia da Silva Perez, Isabelle Augenstein
2023 A* conf
EMNLP
Nadav Borenstein, Phillip Rust, Desmond Elliott, Isabelle Augenstein
2023 J jnl
CoRR
Nadav Borenstein, Phillip Rust, Desmond Elliott, Isabelle Augenstein
2021 conf
ACL/IJCNLP (1)
Chen Shani, Nadav Borenstein, Dafna Shahaf
2021 J jnl
CoRR
Chen Shani, Nadav Borenstein, Dafna Shahaf
redb/extractors/js_extractors/js_deobfuscator.py
← Index redb/extractors/js_extractors/js_deobfuscator.py python
"""Subprocess-driven JavaScript deobfuscator with jsbeautifier fallback.

Owns the heavy lifting that was previously embedded inside
`JSDeobfuscationExtractor` (`_run_deobfuscator` + `_try_jsbeautifier`). Exposed
as a single module-level entry point `deobfuscate(source, log)` so it can be
called from `JSContext.deobfuscated` (cached per sample) without dragging
extractor state through the call.

Configuration (env vars):
    JS_DEOBFUSCATOR_PATH    Path or name of the external tool (default: webcrack).
    JS_DEOBFUSCATE_TIMEOUT  Seconds before the external tool is killed
                            (process-group SIGTERM, then SIGKILL). Default: 60.

If the external tool produces non-empty output and exits 0, that wins. Otherwise
the source is run through jsbeautifier (which only normalises formatting, but
already exposes strings hidden by minification). If neither path produces
output, returns (None, None).

`FileNotFoundError` for the external tool is treated as routine — the analysis
server is either provisioned with the tool or it isn't — and demoted to a
debug-level log.
"""

import os
import signal
import subprocess
import tempfile
from typing import Optional, Tuple

DEFAULT_DEOBFUSCATOR = "webcrack"
DEFAULT_TIMEOUT_SECS = 60


def _run_external(
    source: str, deobfuscator_path: str, timeout: int, log
) -> Tuple[Optional[str], int]:
    """Run the configured external deobfuscator over `source` and capture stdout.

    Returns (text, returncode). `text` is `None` and `returncode` is `-1` when
    the binary is missing, the run timed out, or any other unexpected failure
    occurred. Missing-binary is logged at debug; timeouts and unexpected errors
    surface at warning/error.
    """
    try:
        with tempfile.NamedTemporaryFile(
            suffix=".js", mode="w", delete=False, encoding="utf-8"
        ) as tmp:
            tmp.write(source)
            tmp_path = tmp.name

        try:
            process = subprocess.Popen(
                [deobfuscator_path, tmp_path],
                stdout=subprocess.PIPE,
                stderr=subprocess.PIPE,
                preexec_fn=os.setsid,
            )

            try:
                stdout, _ = process.communicate(timeout=timeout)
                return stdout.decode("utf-8", errors="replace"), process.returncode
            except subprocess.TimeoutExpired:
                # Kill the entire process group so spawned helpers (e.g. node
                # subprocesses webcrack itself launches) get cleaned up too.
                try:
                    os.killpg(os.getpgid(process.pid), signal.SIGTERM)
                    process.wait(timeout=5)
                except Exception:
                    try:
                        os.killpg(os.getpgid(process.pid), signal.SIGKILL)
                    except Exception:
                        pass
                log.warning(f"Deobfuscation timed out after {timeout}s")
                return None, -1
        finally:
            try:
                os.unlink(tmp_path)
            except Exception:
                pass
    except FileNotFoundError:
        log.debug(f"Deobfuscator binary not found at {deobfuscator_path}")
        return None, -1
    except Exception as e:
        log.error(f"Error running deobfuscator: {e}")
        return None, -1


def _try_jsbeautifier(source: str, log) -> Tuple[Optional[str], Optional[str]]:
    """Fallback path: format the source with jsbeautifier. Returns
    `(text, "jsbeautifier")` or `(None, None)` if jsbeautifier isn't installed
    or the call raised."""
    try:
        import jsbeautifier
        opts = jsbeautifier.default_options()
        opts.indent_size = 2
        return jsbeautifier.beautify(source, opts), "jsbeautifier"
    except ImportError:
        log.debug("jsbeautifier not available")
        return None, None
    except Exception as e:
        log.warning(f"jsbeautifier failed: {e}")
        return None, None


def deobfuscate(source: str, log) -> Tuple[Optional[str], Optional[str]]:
    """Run the configured external deobfuscator, falling back to jsbeautifier.

    Returns `(text, normalizer_used)` on success, or `(None, None)` when neither
    path produced non-empty output. `normalizer_used` is the basename of the
    external tool (e.g. `"webcrack"`) or the literal `"jsbeautifier"`.
    """
    if not source:
        return None, None

    deobfuscator_path = os.getenv("JS_DEOBFUSCATOR_PATH", DEFAULT_DEOBFUSCATOR)
    timeout = int(os.getenv("JS_DEOBFUSCATE_TIMEOUT", str(DEFAULT_TIMEOUT_SECS)))

    text, returncode = _run_external(source, deobfuscator_path, timeout, log)
    if text and returncode == 0 and text.strip():
        return text, os.path.basename(deobfuscator_path)

    return _try_jsbeautifier(source, log)