Iain E. Garden Richardson

30 papers A* 2B 7C 2Misc 1Journal 11Unranked 6
YearRankTypeTitle / Venue / Authors
2012 J jnl
IEEE Trans. Circuits Syst. Video Technol.
Abharana Bhat, C. Sampath Kannangara, Yafan Zhao, Iain E. Garden Richardson
2010 J jnl
IEEE Trans. Circuits Syst. Video Technol.
C. Sampath Kannangara, James M. Philp, Iain E. Garden Richardson, Maja Bystrom, Manuel de-Frutos-López
2010 J jnl
Signal Process. Image Commun.
Abharana Bhat, Iain E. Garden Richardson, C. Sampath Kannangara
2010 J jnl
Signal Process. Image Commun.
Maja Bystrom, Iain E. Garden Richardson, C. Sampath Kannangara, Manuel de-Frutos-López
2009 C conf
PCS
Iain E. Garden Richardson, C. Sampath Kannangara, Maja Bystrom, James M. Philp, Manuel de-Frutos-López
2009 Misc conf
ICASSP
Abharana Bhat, Iain E. Garden Richardson, C. Sampath Kannangara
2009 C conf
PCS
Abharana Bhat, Iain E. Garden Richardson, C. Sampath Kannangara
2009 J jnl
IEEE Trans. Multim.
C. Sampath Kannangara, Iain E. Garden Richardson, Maja Bystrom, Yafan Zhao
2009 B conf
ICIP
James M. Philp, C. Sampath Kannangara, Maja Bystrom, Manuel de-Frutos-López, Iain E. Garden Richardson
2009 B conf
ICIP
Iain E. Garden Richardson, C. Sampath Kannangara, Maja Bystrom, James M. Philp, Manuel de-Frutos-López
2008 J jnl
IEEE Trans. Circuits Syst. Video Technol.
C. Sampath Kannangara, Iain E. Garden Richardson, A. J. Miller
2008 B conf
ICIP
Iain E. Garden Richardson, Maja Bystrom, Manuel de-Frutos-López, C. Sampath Kannangara
2008 J jnl
Signal Process. Image Commun.
Maja Bystrom, Iain E. Garden Richardson, Yafan Zhao
2008 B conf
ICIP
C. Sampath Kannangara, Iain E. Garden Richardson, Maja Bystrom, Manuel de-Frutos-López
2008 conf
SoCC
Iain E. Garden Richardson
2006 B conf
ICIP
Yafan Zhao, Maja Bystrom, Iain E. Garden Richardson
2006 J jnl
IEEE Trans. Circuits Syst. Video Technol.
C. Sampath Kannangara, Iain E. Garden Richardson, Maja Bystrom, J. R. Solera, Yafan Zhao, Andrew MacLennan, Robert Cooney
2005 conf
EUSIPCO
Wei Wei Lee, Iain E. Garden Richardson, Ken Gow, Yafan Zhao, Roger T. Staff
2004 conf
ICIAR (1)
Ying Zhong, Iain E. Garden Richardson, Arash Sahraie, Peter McGeorge
2004 B conf
ICIP
Iain E. Garden Richardson, Yafan Zhao
2003 book
Iain E. Garden Richardson
2003 J jnl
Signal Process. Image Commun.
Yafan Zhao, Iain E. Garden Richardson
2002 J jnl
Real Time Imaging
Iain E. Garden Richardson, Yafan Zhao
2002 A* conf
ACM Multimedia
Yafan Zhao, Iain E. Garden Richardson
2002 B conf
DCC
Yafan Zhao, Iain E. Garden Richardson
2002 A* conf
ACM Multimedia
Laura J. Muir, Iain E. Garden Richardson
2001 conf
ICIP (1)
Iain E. Garden Richardson, Yafan Zhao
1995 J jnl
Signal Process.
Iain E. Garden Richardson, Martyn J. Riley
1994 conf
Broadband Islands
Iain E. Garden Richardson, Martyn J. Riley
1994 conf
Modelling and Evaluation of ATM Networks
Martyn J. Riley, Iain E. Garden Richardson
tests/unit/test_apk_jadx_wrapper.py
← Index tests/unit/test_apk_jadx_wrapper.py python
"""
Unit tests for JADX wrapper subprocess management and output parsing.

All subprocess calls are mocked — no JADX/Java installation required.
"""
import os
import tempfile
import textwrap

import pytest
from unittest.mock import MagicMock, patch, call

pytestmark = [pytest.mark.unit, pytest.mark.apk, pytest.mark.decompile]


class TestJADXDecompiler:
    """Tests for JADXDecompiler subprocess wrapper."""

    @patch.dict(os.environ, {}, clear=False)
    def test_init_defaults(self):
        os.environ.pop("JADX_PATH", None)
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        assert j.jadx_path == "jadx"
        assert j.timeout == 300

    def test_init_custom_path(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler(jadx_path="/usr/local/bin/jadx", timeout=300)
        assert j.jadx_path == "/usr/local/bin/jadx"
        assert j.timeout == 300

    def test_init_from_env(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        with patch.dict(os.environ, {"JADX_PATH": "/opt/jadx/bin/jadx", "JADX_TIMEOUT": "120"}):
            j = JADXDecompiler()
            assert j.jadx_path == "/opt/jadx/bin/jadx"
            assert j.timeout == 120

    @patch("subprocess.Popen")
    def test_decompile_success(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        mock_proc = MagicMock()
        mock_proc.communicate.return_value = ("output", "")
        mock_proc.returncode = 0
        mock_popen.return_value = mock_proc

        j = JADXDecompiler()
        result = j.decompile("/test.apk", "/output")
        assert result is True

    @patch("subprocess.Popen")
    def test_decompile_nonzero_exit_no_sources(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        mock_proc = MagicMock()
        mock_proc.communicate.return_value = ("", "error msg")
        mock_proc.returncode = 1
        mock_popen.return_value = mock_proc

        j = JADXDecompiler(log=MagicMock())
        result = j.decompile("/test.apk", "/nonexistent_output")
        assert result is False

    @patch("subprocess.Popen")
    def test_decompile_timeout(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        import subprocess
        mock_proc = MagicMock()
        mock_proc.communicate.side_effect = subprocess.TimeoutExpired(cmd="jadx", timeout=10)
        mock_proc.pid = 12345
        mock_popen.return_value = mock_proc

        with patch("os.getpgid", return_value=12345), \
             patch("os.killpg"):
            j = JADXDecompiler(timeout=10, log=MagicMock())
            result = j.decompile("/test.apk", "/output")
            assert result is False

    @patch("subprocess.Popen", side_effect=FileNotFoundError)
    def test_decompile_not_found(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler(log=MagicMock())
        result = j.decompile("/test.apk", "/output")
        assert result is False

    @patch("subprocess.Popen")
    def test_decompile_command_args(self, mock_popen):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        mock_proc = MagicMock()
        mock_proc.communicate.return_value = ("", "")
        mock_proc.returncode = 0
        mock_popen.return_value = mock_proc

        j = JADXDecompiler(jadx_path="/opt/jadx")
        j.decompile("/test.apk", "/output")

        cmd = mock_popen.call_args[0][0]
        assert cmd[0] == "/opt/jadx"
        assert "--no-res" in cmd
        assert "--no-imports" in cmd
        assert "--threads-count" in cmd
        assert "/test.apk" in cmd

    def test_parse_java_methods_empty_dir(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        result = j.parse_java_methods("/nonexistent")
        assert result == {}

    def test_parse_java_methods_with_files(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        with tempfile.TemporaryDirectory() as tmpdir:
            sources_dir = os.path.join(tmpdir, "sources", "com", "example")
            os.makedirs(sources_dir)

            java_content = textwrap.dedent("""\
                package com.example;

                public class MyClass {
                    public void doStuff(int x) {
                        System.out.println(x);
                    }

                    private String getName() {
                        return "test";
                    }
                }
            """)
            with open(os.path.join(sources_dir, "MyClass.java"), "w") as f:
                f.write(java_content)

            j = JADXDecompiler()
            methods = j.parse_java_methods(tmpdir)
            assert len(methods) >= 1

    def test_extract_methods_from_java(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        source = textwrap.dedent("""\
            public void foo(int x) {
                if (x > 0) {
                    System.out.println(x);
                }
            }
        """)
        j = JADXDecompiler()
        methods = j._extract_methods_from_java(source, "com.example.Test")
        assert len(methods) == 1
        key = list(methods.keys())[0]
        assert "foo" in key

    def test_is_method_declaration_valid(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        result = j._is_method_declaration("    public void foo(int x) {")
        assert result is not None
        assert result[0] == "foo"

    def test_is_method_declaration_control_flow(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        # 'if', 'for', etc. should not be recognized as methods
        assert j._is_method_declaration("        if (x > 0) {") is None
        assert j._is_method_declaration("        for (int i = 0; i < 10; i++) {") is None

    def test_is_method_declaration_static(self):
        from redb.extractors.decompiler.apk.jadx_wrapper import JADXDecompiler
        j = JADXDecompiler()
        result = j._is_method_declaration("    public static void main(String[] args) {")
        assert result is not None
        assert result[0] == "main"